Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19208#discussion_r139568979
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -237,12 +251,17 @@ object CrossValidator extends
MLReadable[CrossValidator] {
class CrossValidatorModel private[ml] (
@Since("1.4.0") override val uid: String,
@Since("1.2.0") val bestModel: Model[_],
- @Since("1.5.0") val avgMetrics: Array[Double])
+ @Since("1.5.0") val avgMetrics: Array[Double],
+ @Since("2.3.0") val subModels: Array[Array[Model[_]]])
extends Model[CrossValidatorModel] with CrossValidatorParams with
MLWritable {
/** A Python-friendly auxiliary constructor. */
private[ml] def this(uid: String, bestModel: Model[_], avgMetrics:
JList[Double]) = {
- this(uid, bestModel, avgMetrics.asScala.toArray)
+ this(uid, bestModel, avgMetrics.asScala.toArray, null)
--- End diff --
See earlier suggestion, use an Option set to `None` instead of setting the
Array to null
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
