Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r143628760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
foldFunctions: Seq[String] => String = _.mkString("", ";\n", ";")):
String = {
val blocks = new ArrayBuffer[String]()
val blockBuilder = new StringBuilder()
+ val maxLines = SQLConf.get.maxCodegenLinesPerFunction
--- End diff --
@gatorsmile Since to make it configurable [takes long
time](https://github.com/apache/spark/pull/19449#discussion_r143385878), can we
do it using hard-coded parameter?
Even in this case, this PR makes better since the estimation does not
include characters for comment.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
