Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r143629417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,21 @@ class CodegenContext {
foldFunctions: Seq[String] => String = _.mkString("", ";\n", ";")):
String = {
val blocks = new ArrayBuffer[String]()
val blockBuilder = new StringBuilder()
+ val maxLines = SQLConf.get.maxCodegenLinesPerFunction
--- End diff --
@kiszk You know, I am just afraid new regression could be introduced due to
this change. Sorry for the delay. I really do not have a better solution. I
kind of agree on your original solution. Just exclude the characters for
comment. At least, it becomes better and take a less risk to hit a regression.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
