Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19474#discussion_r144197368
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
 ---
    @@ -30,4 +31,12 @@ class FileFormatWriterSuite extends QueryTest with 
SharedSQLContext {
           assert(partFiles.length === 2)
         }
       }
    +
    +  test("FileFormatWriter should respect the input query schema") {
    +    withTable("t1", "t2") {
    +      spark.range(1).select('id as 'col1, 'id as 
'col2).write.saveAsTable("t1")
    --- End diff --
    
    Also add another case here?
    ```
    spark.range(1).select('id, 'id as 'col1, 'id as 
'col2).write.saveAsTable("t3")
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to