Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19474#discussion_r144197934
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala
 ---
    @@ -30,6 +31,15 @@ import org.apache.spark.util.SerializableConfiguration
      */
     trait DataWritingCommand extends RunnableCommand {
     
    +  def query: LogicalPlan
    +
    +  // We make the input `query` an inner child instead of a child in order 
to hide it from the
    +  // optimizer. This is because optimizer may change the output schema 
names, and we have to keep
    --- End diff --
    
    You will scare others. :) 
    
    -> `may not preserve the output schema names' case`



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to