Github user ArtRand commented on a diff in the pull request:
https://github.com/apache/spark/pull/19390#discussion_r144682379
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -469,6 +474,12 @@ trait MesosSchedulerUtils extends Logging {
.setType(Value.Type.RANGES)
.setRanges(Value.Ranges.newBuilder().addRange(rangeValue))
role.foreach(r => builder.setRole(r))
+
+ if (role.forall(r => !r.equals("*"))) {
--- End diff --
Maybe abstract this logic into a general function?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
