Github user ArtRand commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19437#discussion_r144680489
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
 ---
    @@ -170,9 +175,119 @@ private[mesos] object MesosSchedulerBackendUtil 
extends Logging {
           containerInfo.addNetworkInfos(info)
         }
     
    +    getSecretVolume(conf, secretConfig).foreach { volume =>
    +      if (volume.getSource.getSecret.getReference.isInitialized) {
    +        logInfo(s"Setting reference secret 
${volume.getSource.getSecret.getReference.getName}" +
    +          s"on file ${volume.getContainerPath}")
    +      } else {
    +        logInfo(s"Setting secret on file name=${volume.getContainerPath}")
    +      }
    +      containerInfo.addVolumes(volume)
    +    }
    +
         containerInfo
       }
     
    +  def addSecretEnvVar(
    +      envBuilder: Environment.Builder,
    +      conf: SparkConf,
    +      secretConfig: MesosSecretConfig): Unit = {
    +    getSecretEnvVar(conf, secretConfig).foreach { variable =>
    +      if (variable.getSecret.getReference.isInitialized) {
    +        logInfo(s"Setting reference secret 
${variable.getSecret.getReference.getName}" +
    --- End diff --
    
    Space at the end of this log line too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to