[GitHub] spark pull request #19988: [Spark-22795] [ML] Raise error when line search i...

[WeichenXu123]

Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19988#discussion_r157393049
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
    @@ -244,9 +244,9 @@ class LinearSVC @Since("2.2.0") (
           }
     
           bcFeaturesStd.destroy(blocking = false)
    -      if (state == null) {
    +      if (state == null || state.searchFailed) {
             val msg = s"${optimizer.getClass.getName} failed."
    -        logError(msg)
    +        logWarning(msg)
             throw new SparkException(msg)
    --- End diff --
    
    But the msg in the Exception should include the root reason "line search 
failed." Current msg only including "LBFGS failed."


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org