Github user mrkm4ntr commented on a diff in the pull request:
https://github.com/apache/spark/pull/19988#discussion_r157396794
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
@@ -244,9 +244,9 @@ class LinearSVC @Since("2.2.0") (
}
bcFeaturesStd.destroy(blocking = false)
- if (state == null) {
+ if (state == null || state.searchFailed) {
val msg = s"${optimizer.getClass.getName} failed."
- logError(msg)
+ logWarning(msg)
throw new SparkException(msg)
--- End diff --
The message that line search failed is logged by breeze.
https://github.com/scalanlp/breeze/blob/4611fe3f4466ac5b1885e9d6288ba27fc9d205ec/math/src/main/scala/breeze/optimize/FirstOrderMinimizer.scala#L78
I think it is a bit verbose that logging at this place.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
