Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19591#discussion_r158201743 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -210,8 +209,13 @@ int getPort() { * Removes the client handle from the pending list (in case it's still there), and unrefs * the server. */ - void unregister(ChildProcAppHandle handle) { - pending.remove(handle.getSecret()); + void unregister(AbstractAppHandle handle) { + for (Map.Entry<String, AbstractAppHandle> e : pending.entrySet()) { --- End diff -- you could add a system.identityHashCode "secret" to the InProcessAppHandle to keep the old version, though this is fine too
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org