Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19591#discussion_r158201527
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -260,24 +264,30 @@ private long getConnectionTimeout() {
}
private String createSecret() {
- byte[] secret = new byte[128];
- RND.nextBytes(secret);
-
- StringBuilder sb = new StringBuilder();
- for (byte b : secret) {
- int ival = b >= 0 ? b : Byte.MAX_VALUE - b;
- if (ival < 0x10) {
- sb.append("0");
+ while (true) {
--- End diff --
checking my understanding -- extra bug fix here? even in old code, if by
chance two apps had same secret, you'd end up losing one handle?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
