Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20076#discussion_r158629711 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetOptions.scala --- @@ -42,8 +43,15 @@ private[parquet] class ParquetOptions( * Acceptable values are defined in [[shortParquetCompressionCodecNames]]. */ val compressionCodecClassName: String = { --- End diff -- We could alternatively say `compressionCodecName` here. It's rather names like `UNCOMPRESSED`, `LZO`, etc in this case. For the text based sources, they are canonical class names so I am okay with `compressionCodecClassName` but for ORC and Parquet these are not classes.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org