Github user fjh100456 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20076#discussion_r158632847
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetOptions.scala
 ---
    @@ -42,8 +43,15 @@ private[parquet] class ParquetOptions(
        * Acceptable values are defined in 
[[shortParquetCompressionCodecNames]].
        */
       val compressionCodecClassName: String = {
    --- End diff --
    
    @gatorsmile @HyukjinKwon 
    In `TextOptions` ,`JSONOptions` and `CSVOptions`, it's  "Option[String]", 
but in `OrcOptions` and `ParquetOptions`, it's a "String".
    Just change `compressionCodecClassName` in `OrcOptions` and 
`ParquetOptions` to `compressionCodecName` is ok ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to