Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20177#discussion_r162749089
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ---
    @@ -154,11 +155,17 @@ abstract class SQLViewSuite extends QueryTest with 
SQLTestUtils {
           assertNoSuchTable(s"TRUNCATE TABLE $viewName")
           assertNoSuchTable(s"SHOW CREATE TABLE $viewName")
           assertNoSuchTable(s"SHOW PARTITIONS $viewName")
    -      assertNoSuchTable(s"ANALYZE TABLE $viewName COMPUTE STATISTICS")
    -      assertNoSuchTable(s"ANALYZE TABLE $viewName COMPUTE STATISTICS FOR 
COLUMNS id")
    +      assertAnalysisException(s"ANALYZE TABLE $viewName COMPUTE 
STATISTICS")
    --- End diff --
    
    We should also check the error message to ensure the `AnalysisException` is 
not thrown from elsewhere.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to