Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20405#discussion_r164191381
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1216,7 +1216,7 @@ class Dataset[T] private[sql](
*/
@scala.annotation.varargs
def hint(name: String, parameters: Any*): Dataset[T] = withTypedPlan {
- UnresolvedHint(name, parameters, logicalPlan)
+ UnresolvedHint(name, parameters, planWithBarrier)
--- End diff --
My understanding however is that `planWithBarrier` is already analyzed (and
`ResolveBroadcastHints` as the very first rule had its chance to do its work).
That's the extra processing `hint` does every time it's called. Using
`planWithBarrier` makes it less "painful".
Just use `hint` twice and see the analyzed plan.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
