Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20405#discussion_r164267100
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1216,7 +1216,7 @@ class Dataset[T] private[sql](
*/
@scala.annotation.varargs
def hint(name: String, parameters: Any*): Dataset[T] = withTypedPlan {
- UnresolvedHint(name, parameters, logicalPlan)
+ UnresolvedHint(name, parameters, planWithBarrier)
--- End diff --
I thought that that's what `ResolveBroadcastHints` does -->
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala#L93-L101,
doesn't it? I'm going to write a test case for it to confirm (and that's what
I was asking for in the email to dev@spark the other day).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
