Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20438#discussion_r164728359
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
---
@@ -87,7 +87,7 @@ public static CalendarInterval fromString(String s) {
}
}
- public static long toLongWithRange(String fieldName,
+ private static long toLongWithRange(String fieldName,
--- End diff --
Why?! It's much harder (if at all possible) to test `private` methods (been
bitten few times this week and remember the pain).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
