Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20438#discussion_r164730300
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarArray.java ---
    @@ -135,9 +135,7 @@ public UTF8String getUTF8String(int ordinal) {
     
       @Override
       public CalendarInterval getInterval(int ordinal) {
    -    int month = data.getChild(0).getInt(offset + ordinal);
    -    long microseconds = data.getChild(1).getLong(offset + ordinal);
    -    return new CalendarInterval(month, microseconds);
    +    return data.getInterval(offset + ordinal);
    --- End diff --
    
    Good catch! I'm going to require `ColumnVector.getXXX` to return null if 
the value is null, but I'll do it in another PR, to update all the documents 
and define the behavior of batched `getXXX` methods.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to