Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175332253
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -342,8 +349,8 @@ object TypeCoercion {
p.makeCopy(Array(left, Cast(right, TimestampType)))
case p @ BinaryComparison(left, right)
- if findCommonTypeForBinaryComparison(left.dataType,
right.dataType).isDefined =>
- val commonType = findCommonTypeForBinaryComparison(left.dataType,
right.dataType).get
+ if findCommonTypeForBinaryComparison(left.dataType,
right.dataType, conf).isDefined =>
--- End diff --
two more spaces before `if`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
