Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20774#discussion_r175332237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -125,29 +125,36 @@ object TypeCoercion {
/**
* This function determines the target type of a comparison operator
when one operand
* is a String and the other is not. It also handles when one op is a
Date and the
- * other is a Timestamp by making the target type to be String.
+ * other is a Timestamp by making the target type to be Timestamp as
default
*/
- val findCommonTypeForBinaryComparison: (DataType, DataType) =>
Option[DataType] = {
+ private def findCommonTypeForBinaryComparison(dt1: DataType, dt2:
DataType, conf: SQLConf):
+ Option[DataType] = (dt1, dt2) match {
--- End diff --
```Scala
private def findCommonTypeForBinaryComparison(
dt1: DataType, dt2: DataType, conf: SQLConf): Option[DataType] =
(dt1, dt2) match {
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
