Github user misutoth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20853#discussion_r175539256
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -105,11 +105,17 @@ class SparkSubmitSuite
     
       // Necessary to make ScalaTest 3.x interrupt a thread on the JVM like 
ScalaTest 2.2.x
       implicit val defaultSignaler: Signaler = ThreadSignaler
    +  var dir: File = null
    --- End diff --
    
    I was thinking about this too. I wanted to avoid making it an Option or 
doing a not very nice null check. I can do that later though...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to