Github user misutoth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20853#discussion_r175543984
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -245,6 +245,19 @@ object SparkSubmit extends CommandLineUtils with 
Logging {
           args: SparkSubmitArguments,
           conf: Option[HadoopConfiguration] = None)
           : (Seq[String], Seq[String], SparkConf, String) = {
    +    try {
    +      doPrepareSubmitEnvironment(args, conf)
    +    } catch {
    +      case e: SparkException =>
    +        printErrorAndExit(e.getMessage)
    +        throw new RuntimeException("Unreachable production code")
    --- End diff --
    
    Otherwise execution just continues in the test itself where `exitFn` does 
not stop it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to