Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191978140
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/StreamInterceptor.java
---
@@ -50,16 +52,22 @@
@Override
public void exceptionCaught(Throwable cause) throws Exception {
- handler.deactivateStream();
+ deactivateStream();
callback.onFailure(streamId, cause);
}
@Override
public void channelInactive() throws Exception {
- handler.deactivateStream();
+ deactivateStream();
callback.onFailure(streamId, new ClosedChannelException());
}
+ private void deactivateStream() {
+ if (handler instanceof TransportResponseHandler) {
--- End diff --
the only purpose of `TransportResponseHandler.deactivateStream()` is to
include the stream request in the count for `numOutstandingRequests` (its not
doing any critical cleanup). I will include a comment here explaining that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
