Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191978545
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -141,26 +141,14 @@ public void fetchChunk(
StreamChunkId streamChunkId = new StreamChunkId(streamId, chunkIndex);
handler.addFetchRequest(streamChunkId, callback);
- channel.writeAndFlush(new
ChunkFetchRequest(streamChunkId)).addListener(future -> {
--- End diff --
yes exactly. Marcelo asked for this refactoring in his review -- there was
already a ton of copy-paste, and instead of adding more made sense to refactor.
Shouldn't be any behavior change (there are minor changes that shouldn't
matter ... `channel.close()` happens before the more specific cleanup
operations whereas it was in the middle previously, the `try` encompasses a bit
more than before.)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
