Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21482#discussion_r193941785
  
    --- Diff: R/pkg/NAMESPACE ---
    @@ -281,6 +281,8 @@ exportMethods("%<=>%",
                   "initcap",
                   "input_file_name",
                   "instr",
    +              "isInf",
    +              "isinf",
    --- End diff --
    
    I think we shouldn't add other variants unless there's a clear reason. It 
sounds like we are adding this for no reason.
    
    > how about we just go with isInf for now and if other aliases are needed 
in the future they can be added and discussed then?
    
    Yea, please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to