Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21482#discussion_r194610745
  
    --- Diff: R/pkg/NAMESPACE ---
    @@ -281,6 +281,8 @@ exportMethods("%<=>%",
                   "initcap",
                   "input_file_name",
                   "instr",
    +              "isInf",
    +              "isinf",
    --- End diff --
    
    Ah, I got it now. I believe we should match it to one side though. I 
roughly remember we keep functions this_naming_style in 
functions[.py|.R|.scala], 
e.g.([SPARK-10621](https://issues.apache.org/jira/browse/SPARK-10621)). Shall 
we stick to `isinf` then?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to