Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21370#discussion_r194277082
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -3209,6 +3222,19 @@ class Dataset[T] private[sql](
         }
       }
     
    +  private[sql] def getRowsToPython(
    --- End diff --
    
    In DataFrameSuite, we have multiple test cases for `showString` instead of 
`getRows `, which is introduced in this PR. 
    
    We also need the unit test cases for `getRowsToPython`. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to