Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r194278100
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -351,8 +354,68 @@ def show(self, n=20, truncate=True, vertical=False):
else:
print(self._jdf.showString(n, int(truncate), vertical))
+ @property
+ def _eager_eval(self):
+ """Returns true if the eager evaluation enabled.
+ """
+ return self.sql_ctx.getConf(
+ "spark.sql.repl.eagerEval.enabled", "false").lower() == "true"
--- End diff --
Probably, we should access to SQLConf object. 1. Agree with not hardcoding
it in general but 2. IMHO I want to avoid Py4J JVM accesses in the test because
the test can likely be more flaky up to my knowledge, on the other hand (unlike
Scala or Java side).
Maybe we should try to take a look about this hardcoding if we see more
occurrences next time
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
