Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/21662#discussion_r199278041
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -315,8 +315,10 @@ object UnsupportedOperationChecker {
case GroupingSets(_, _, child, _) if child.isStreaming =>
throwError("GroupingSets is not supported on streaming
DataFrames/Datasets")
- case GlobalLimit(_, _) | LocalLimit(_, _) if
subPlan.children.forall(_.isStreaming) =>
- throwError("Limits are not supported on streaming
DataFrames/Datasets")
+ case GlobalLimit(_, _) | LocalLimit(_, _) if
+ subPlan.children.forall(_.isStreaming) && outputMode ==
InternalOutputModes.Update =>
--- End diff --
It is today (though as we discussed I think the query planner would be a
better place if we were to rearchitect).
Style nit: line break at the high syntactic level (i.e. before the if) and
indent 4 space for a continuation like this (to distinguish the guard from the
code executed when matched.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
