Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/21662#discussion_r199278369
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -72,6 +72,8 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
case Limit(IntegerLiteral(limit), Project(projectList, Sort(order,
true, child)))
if limit < conf.topKSortFallbackThreshold =>
TakeOrderedAndProjectExec(limit, order, projectList,
planLater(child)) :: Nil
+ case Limit(IntegerLiteral(limit), child) if plan.isStreaming =>
+ StreamingLimitExec(limit, planLater(child)) :: Nil
--- End diff --
I would create a different one only to continue the pattern of isolating
streaming specific Strategies. You'll then need to inject your new Strategy in
`IncrementalExecution`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
