Github user mukulmurthy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21662#discussion_r199300670
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkSuite.scala
 ---
    @@ -70,35 +68,9 @@ class MemorySinkSuite extends StreamTest with 
BeforeAndAfter {
         checkAnswer(sink.allData, 1 to 9)
       }
     
    -  test("directly add data in Append output mode with row limit") {
    --- End diff --
    
    I thought about it, but I didn't want to have the feature not working (even 
though no one is probably using it), and figured it would be easier this way 
since there's basically no file overlap between the two (except for a test 
class).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to