Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21815#discussion_r203669375
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
 ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution
    +
    +import org.apache.spark.sql.test.SharedSQLContext
    +
    +class FileSourceScanExecSuite extends SharedSQLContext {
    +  test("FileSourceScanExec should be canonicalizable in executor side") {
    +    withTempPath { path =>
    +      spark.range(1).toDF().write.parquet(path.getAbsolutePath)
    +      val df = spark.read.parquet(path.getAbsolutePath)
    +      val fileSourceScanExec =
    +        
df.queryExecution.sparkPlan.find(_.isInstanceOf[FileSourceScanExec]).get
    +      try {
    +        spark.range(1).foreach(_ => fileSourceScanExec.canonicalized)
    --- End diff --
    
    not sure whether it is feasible (maybe in a followup?), but it would be 
great if we can test the canonicalization of all the Exec nodes in order to 
prevent such issue in the future... what do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to