Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203671394
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -199,7 +199,7 @@ case class FileSourceScanExec(
ret
}
- override val (outputPartitioning, outputOrdering): (Partitioning,
Seq[SortOrder]) = {
+ override lazy val (outputPartitioning, outputOrdering): (Partitioning,
Seq[SortOrder]) = {
--- End diff --
it'd be computed anyway, though, when we create a new `FileSourceScanExec`
in the canonicalization process, if it is not lazy, so I'd say that this is
needed, as well as all the others.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
