Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21818#discussion_r203934743
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala
---
@@ -91,8 +92,12 @@ case class InsertIntoHadoopFsRelationCommand(
val pathExists = fs.exists(qualifiedOutputPath)
- val enableDynamicOverwrite =
- sparkSession.sessionState.conf.partitionOverwriteMode ==
PartitionOverwriteMode.DYNAMIC
+ val parameters = CaseInsensitiveMap(options)
+
+ val enableDynamicOverwrite = parameters.get("partitionOverwriteMode")
+ .map(mode => PartitionOverwriteMode.withName(mode.toUpperCase))
+ .getOrElse(sparkSession.sessionState.conf.partitionOverwriteMode) ==
+ PartitionOverwriteMode.DYNAMIC
--- End diff --
nit: this is too long
```
val partitionOverwriteMode = parameters.get("partitionOverwriteMode")....
val enableDynamicOverwrite = partitionOverwriteMode ==
PartitionOverwriteMode.DYNAMIC
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
