Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21818#discussion_r203934987
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala ---
@@ -486,6 +486,25 @@ class InsertSuite extends DataSourceTest with
SharedSQLContext {
}
}
}
+ test("SPARK-24860: dynamic partition overwrite specified per source
without catalog table") {
+ withTempPath { path =>
+ Seq((1, 1, 1)).toDF("i", "part1", "part2")
--- End diff --
can we simplify the test? ideally we only need one partition column, and
write some initial data to the table. then do an overwrite with
partitionOverwriteMode=dynamic, and another overwrite with
partitionOverwriteMode=static.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
