Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21772#discussion_r204276788
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -726,9 +726,10 @@ private[execution] final class LongToUnsafeRowMap(val
mm: TaskMemoryManager, cap
writeLong(array.length)
writeLongArray(writeBuffer, array, array.length)
- val used = ((cursor - Platform.LONG_ARRAY_OFFSET) / 8).toInt
- writeLong(used)
- writeLongArray(writeBuffer, page, used)
+
+ val usedWordsNumber = ((cursor - Platform.LONG_ARRAY_OFFSET) / 8).toInt
+ writeLong(usedWordsNumber)
+ writeLongArray(writeBuffer, page, usedWordsNumber)
--- End diff --
If no good reason, shall we revert this change? Looks like you only rename
it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
