Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21772#discussion_r204618320
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala
 ---
    @@ -278,6 +278,39 @@ class HashedRelationSuite extends SparkFunSuite with 
SharedSQLContext {
         map.free()
       }
     
    +  test("SPARK-24809: Serializing LongHashedRelation in executor may result 
in data error") {
    +    val unsafeProj = UnsafeProjection.create(Array[DataType](LongType))
    +    val originalMap = new LongToUnsafeRowMap(mm, 1)
    +
    +    val key1 = 1L
    +    val value1 = new Random().nextLong()
    +
    +    val key2 = 2L
    +    val value2 = new Random().nextLong()
    --- End diff --
    
    Is it necessary to use `Random` here? Can we use two arbitrary long values?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to