Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21857#discussion_r205565594
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -532,9 +532,13 @@ abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
           case logical.Intersect(left, right) =>
             throw new IllegalStateException(
               "logical intersect operator should have been replaced by 
semi-join in the optimizer")
    -      case logical.Except(left, right) =>
    +      case logical.Except(left, right, false) =>
             throw new IllegalStateException(
               "logical except operator should have been replaced by anti-join 
in the optimizer")
    +      case logical.Except(left, right, true) =>
    +        throw new IllegalStateException(
    +          "logical except operator should have been replaced by union, 
aggregate" +
    --- End diff --
    
    hmm, it looks no diff to above one. Maybe `except (all) operator`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to