Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21921#discussion_r206936701
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
---
@@ -456,57 +445,20 @@ class AdvancedInputPartition(start: Int, end: Int,
requiredSchema: StructType)
current < end
}
- override def get(): Row = {
+ override def get(): InternalRow = {
val values = requiredSchema.map(_.name).map {
case "i" => current
case "j" => -current
}
- Row.fromSeq(values)
+ InternalRow.fromSeq(values)
}
}
-class UnsafeRowDataSourceV2 extends DataSourceV2 with ReadSupport {
--- End diff --
These aren't Row implementations. Why remove them?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
