Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21921#discussion_r206944875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
---
@@ -416,12 +405,12 @@ class AdvancedDataSourceV2 extends DataSourceV2 with
ReadSupport {
requiredSchema
}
- override def planRowInputPartitions(): JList[InputPartition[Row]] = {
- val lowerBound = filters.collect {
+ override def planInputPartitions(): JList[InputPartition[InternalRow]]
= {
+ val lowerBound = filters.collectFirst {
--- End diff --
I agree but this is really minor. When I changed the code nearby, the IDE
shows a warning for not using `collectFirst` here. Then I went for it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
