Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22031#discussion_r210466854
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
 ---
    @@ -687,3 +687,89 @@ case class MapZipWith(left: Expression, right: 
Expression, function: Expression)
     
       override def prettyName: String = "map_zip_with"
     }
    +
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = "_FUNC_(left, right, func) - Merges the two given arrays, 
element-wise, into a single array using function. If one array is shorter, 
nulls are appended at the end to match the length of the longer array, before 
applying function.",
    +  examples = """
    +    Examples:
    +      > SELECT _FUNC_(array(1, 2, 3), array('a', 'b', 'c'), (x, y) -> (y, 
x));
    +       array(('a', 1), ('b', 3), ('c', 5))
    +      > SELECT _FUNC_(array(1, 2), array(3, 4), (x, y) -> x + y));
    +       array(4, 6)
    +      > SELECT _FUNC_(array('a', 'b', 'c'), array('d', 'e', 'f'), (x, y) 
-> concat(x, y));
    +       array('ad', 'be', 'cf')
    +  """,
    +  since = "2.4.0")
    +// scalastyle:on line.size.limit
    +case class ZipWith(left: Expression, right: Expression, function: 
Expression)
    +  extends HigherOrderFunction with CodegenFallback {
    +
    +  def functionForEval: Expression = functionsForEval.head
    +
    +  override def arguments: Seq[Expression] = left :: right :: Nil
    +
    +  override def argumentTypes: Seq[AbstractDataType] = ArrayType :: 
ArrayType :: Nil
    +
    +  override def functions: Seq[Expression] = List(function)
    +
    +  override def functionTypes: Seq[AbstractDataType] = AnyDataType :: Nil
    +
    +  override def nullable: Boolean = left.nullable || right.nullable
    +
    +  override def dataType: ArrayType = ArrayType(function.dataType, 
function.nullable)
    +
    +  override def bind(f: (Expression, Seq[(DataType, Boolean)]) => 
LambdaFunction): ZipWith = {
    +    val (leftElementType, leftContainsNull) = left.dataType match {
    +      case ArrayType(elementType, containsNull) => (elementType, 
containsNull)
    +      case _ =>
    +        val ArrayType(elementType, containsNull) = 
ArrayType.defaultConcreteType
    +        (elementType, containsNull)
    +    }
    +    val (rightElementType, rightContainsNull) = right.dataType match {
    +      case ArrayType(elementType, containsNull) => (elementType, 
containsNull)
    +      case _ =>
    +        val ArrayType(elementType, containsNull) = 
ArrayType.defaultConcreteType
    +        (elementType, containsNull)
    +    }
    --- End diff --
    
    Now we can do:
    
    ```scala
    val ArrayType(leftElementType, leftContainsNull) = left.dataType
    val ArrayType(rightElementType, rightContainsNull) = right.dataType
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to