Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467535
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -396,4 +396,52 @@ class HigherOrderFunctionsSuite extends SparkFunSuite
with ExpressionEvalHelper
map_zip_with(mbb0, mbbn, concat),
null)
}
+
+ test("ZipWith") {
+ def zip_with(
+ left: Expression,
+ right: Expression,
+ f: (Expression, Expression) => Expression): Expression = {
+ val ArrayType(leftT, leftContainsNull) =
left.dataType.asInstanceOf[ArrayType]
+ val ArrayType(rightT, rightContainsNull) =
right.dataType.asInstanceOf[ArrayType]
--- End diff --
nit: we don't need `.asInstanceOf[ArrayType]`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
