Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22320#discussion_r215215098
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -754,6 +754,54 @@ class HiveDDLSuite
         }
       }
     
    +  test("Insert overwrite Hive table should output correct schema") {
    +    withSQLConf(CONVERT_METASTORE_PARQUET.key -> "false") {
    +      withTable("tbl", "tbl2") {
    +        withView("view1") {
    +          spark.sql("CREATE TABLE tbl(id long)")
    +          spark.sql("INSERT OVERWRITE TABLE tbl VALUES 4")
    --- End diff --
    
    I might be missing something, but why does this test use SQL statements not 
DataFrameWriter API, e.g. 
`Seq(4).toDF("id").write.mode(SaveMode.Overwrite).saveAsTable("tbl")`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to