Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22320#discussion_r215246692
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
 ---
    @@ -805,6 +805,80 @@ class DataFrameReaderWriterSuite extends QueryTest 
with SharedSQLContext with Be
         }
       }
     
    +  test("Insert overwrite table command should output correct schema: 
basic") {
    +    withTable("tbl", "tbl2") {
    +      withView("view1") {
    +        val df = spark.range(10).toDF("id")
    --- End diff --
    
    I think @gengliangwang meant case preserving, which is the behavior we are 
testing against.
    
    `spark.range(10).toDF("id")` is same as `spark.range(10)`, it's just 
clearer to people who don't know `spark.range` outputs a single column named 
"id".


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to