Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22362#discussion_r216107505
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -520,6 +520,10 @@ private[spark] class SparkSubmit extends Logging {
             confKey = "spark.driver.extraJavaOptions"),
           OptionAssigner(args.driverExtraLibraryPath, ALL_CLUSTER_MGRS, 
ALL_DEPLOY_MODES,
             confKey = "spark.driver.extraLibraryPath"),
    +      OptionAssigner(args.principal, ALL_CLUSTER_MGRS, ALL_DEPLOY_MODES,
    +        confKey = "spark.kerberos.principal"),
    --- End diff --
    
    Since you're changing this, could you use `PRINCIPAL.key` and `KEYTAB.key` 
in the places where the config name is referenced?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to