Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22362#discussion_r216107597
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -199,8 +199,8 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
         numExecutors = Option(numExecutors)
           .getOrElse(sparkProperties.get("spark.executor.instances").orNull)
         queue = 
Option(queue).orElse(sparkProperties.get("spark.yarn.queue")).orNull
    -    keytab = 
Option(keytab).orElse(sparkProperties.get("spark.yarn.keytab")).orNull
    -    principal = 
Option(principal).orElse(sparkProperties.get("spark.yarn.principal")).orNull
    +    keytab = 
Option(keytab).orElse(sparkProperties.get("spark.kerberos.keytab")).orNull
    --- End diff --
    
    This has a similar issue as the R code above re: backwards compatibility.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to