GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22513
[SPARK-25499][TEST]Refactor BenchmarkBase and Benchmark
## What changes were proposed in this pull request?
Currently there are two classes with the same naming BenchmarkBase:
1. `org.apache.spark.util.BenchmarkBase`
2. `org.apache.spark.sql.execution.benchmark.BenchmarkBase`
This is very confusing. And the benchmark object
`org.apache.spark.sql.execution.benchmark.FilterPushdownBenchmark` is using the
one in `org.apache.spark.util.BenchmarkBase`, while there is another class
`BenchmarkBase` in the same package of it.
Here I propose:
1. the package org.apache.spark.util.BenchmarkBase should be in test
package, move to org.apache.spark.sql.execution.benchmark .
2. Rename the org.apache.spark.sql.execution.benchmark.BenchmarkBase as
BenchmarkWithCodegen
3. Move org.apache.spark.util.Benchmark to test package of
org.apache.spark.sql.execution.benchmark
## How was this patch tested?
Unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark refactorBenchmarkBase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22513
----
commit 89bd8300405a6c7f2ed4d756db66b2d1cc3f7389
Author: Gengliang Wang <gengliang.wang@...>
Date: 2018-09-21T05:07:01Z
refactor BenchmarkBase
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
