Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22494#discussion_r219493420
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2858,6 +2858,13 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
         val result = ds.flatMap(_.bar).distinct
         result.rdd.isEmpty
       }
    +
    +  test("SPARK-25454: decimal division with negative scale") {
    +    // TODO: completely fix this issue even LITERAL_PRECISE_PRECISION is 
true.
    --- End diff --
    
    nit: `even when`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to