Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22494#discussion_r219505527
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1345,6 +1345,15 @@ object SQLConf {
           .booleanConf
           .createWithDefault(true)
     
    +  val LITERAL_PICK_MINIMUM_PRECISION =
    +    buildConf("spark.sql.literal.pickMinimumPrecision")
    --- End diff --
    
    nit: I am thinking whether we can consider this as a `legacy` config. We 
can also remove it once the PR for SPARK-25454 will be merged and/or we remove 
the support to negative scale decimals. What do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to