Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22419#discussion_r219651627
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
    @@ -413,6 +413,7 @@ object Decimal {
       val ROUND_HALF_EVEN = BigDecimal.RoundingMode.HALF_EVEN
       val ROUND_CEILING = BigDecimal.RoundingMode.CEILING
       val ROUND_FLOOR = BigDecimal.RoundingMode.FLOOR
    +  val ROUND_DOWN = BigDecimal.RoundingMode.DOWN
    --- End diff --
    
    Need this change, otherwise:
    ```
    Caused by: org.codehaus.commons.compiler.CompileException: File 
'generated.java', Line 41, Column 138: failed to compile: 
org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 41, 
Column 138: A method named "ROUND_DOWN" is not declared in any enclosing class 
nor any supertype, nor through a static import
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to